我的复制构造函数是错误的.它们应该是什么样子?

My copy constructors are wrong. How should they look like?

本文关键字:什么样 复制 构造函数 错误 我的      更新时间:2023-10-16

我有两个简单的类:CreditCard和Account

    #pragma once
    #include<string>
    class CreditCard
    {
    private:
        std::string number;
        int expMonth;
        int expYear;
        int pin;
    public:
        CreditCard():number(""), expMonth(0), expYear(0), pin(0)
        {
        }
        CreditCard(std::string number, int expMonth, int expYear,int pin):number(number), expMonth(expMonth), expYear(expYear), pin(pin)
        {
            if(number.length()!=5)
            {
                throw std::invalid_argument("Card number must be 5 characters");
            }
            if(expMonth<0 || expMonth>12)
            {
                throw std::invalid_argument("Invalid expiration month");
            }
            if(expYear<2014 || expYear>2020)
            {
                throw std::invalid_argument("Invalid expiration year");
            }
            if(pin<1000 || pin>9999)
            {
                throw std::invalid_argument("PIN must be between 1000 and 9999");
            }
        }
        CreditCard(const CreditCard &creditCard):number(creditCard.number), expMonth(creditCard.expMonth), expYear(creditCard.expYear), pin(creditCard.pin)
        {
        }   
        CreditCard(CreditCard &&creditCard):number(std::move(creditCard.number)), expMonth(std::move(creditCard.expMonth)), expYear(std::move(creditCard.expYear)), pin(std::move(creditCard.pin))
        {
            creditCard.number="";
            creditCard.expMonth=0;
            creditCard.expYear=0;
            creditCard.pin=0;
        }
        CreditCard& operator = (const CreditCard &creditCard)
        {
            number=creditCard.number;
            expMonth=creditCard.expMonth;
            expYear=creditCard.expYear;
            pin=creditCard.pin;
            return *this;
        }
        CreditCard& operator = (CreditCard &&creditCard)
        {
            if(this!=&creditCard)
            {
                number=std::move(creditCard.number);
                expMonth=std::move(creditCard.expMonth);
                expYear=std::move(creditCard.expYear);
                pin=std::move(creditCard.pin);
                number=creditCard.number;
                expMonth=creditCard.expMonth;
                expYear=creditCard.expYear;
                pin=creditCard.pin;
            }
            return *this;
        }
        std::string getNumber() const
        {
            return number;
        }
        int getExpMonth() const
        {
            return expMonth;
        }
        int getExpYear() const
        {
            return expYear;
        }
        int getPin() const
        {
            return pin;
        }
    };

#pragma once
#include<string>
#include"CreditCard.h"
class Account
{
private:
    std::string number;
    float amount;
    CreditCard creditCard;
public:
    Account():number(""), amount(0), creditCard()
    {
    }
    Account(std::string number, float amount, CreditCard creditCard) : number(number), amount(amount), creditCard(creditCard)
    {
    }
    Account(const Account &account) : number(account.number), amount(account.amount), creditCard(account.creditCard)
    {
    }
    Account(Account &&account) : number(std::move(account.number)), amount(std::move(account.amount)), creditCard(std::move(creditCard))
    {
    }
    Account& operator = (const Account &account)
    {
        number=account.number;
        amount=account.amount;
        creditCard=account.creditCard;      
        return *this;
    }
    Account& operator = (Account &&account)
    {
        if(this!=&account)
        {
            number=account.number;
            amount=account.amount;
            creditCard=account.creditCard;
            account.number="";
            account.amount=0;
            account.creditCard=CreditCard("",0,0,0);
        }
        return *this;
    }
    std::string getNumber() const
    {
        return number;
    }
    float getAmount() const
    {
        return amount;
    }
    void deposit(const float &depositAmount)
    {
        amount+=depositAmount;
    }
    void withdraw(const float &withdrawAmount)
    {
        amount-=withdrawAmount;
    }
};

因为我是初学者,所以我写的东西几乎都有错误。写move构造函数的正确方法是什么?我的2移动构造函数/移动赋值操作符应该是什么样的?

您的构造函数不需要采取任何特殊的操作,因此您可以使用构造函数的合成版本:

CreditCard(const CreditCard& creditCard)=default;
CreditCard(CreditCard&& creditCard)=default;

等等

如果你真的想实现它们,那么这是一个手工制作移动复制构造函数的例子。注意,在构造函数体中什么也没有发生。

CreditCard(CreditCard&& creditCard)
: 
number(std::move(creditCard.number)), 
expMonth(std::move(creditCard.expMonth)), 
expYear(std::move(creditCard.expYear)), 
pin(std::move(creditCard.pin))
{}

关于复制赋值操作符,如果您关心异常安全,您可能需要查看复制和交换习惯用法

如果您的类成员

std::string number;
int expMonth;
int expYear;
int pin;

,你写一个复制构造函数:

CreditCard(const CreditCard &creditCard):number(creditCard.number),
 expMonth(creditCard.expMonth), expYear(creditCard.expYear), 
 pin(creditCard.pin){}

如果你自己不指定,编译器就会提供这个

你只需要在某些特殊情况下编写复制构造函数,例如,当你必须动态分配指针,并且你不希望指针只是以上述方式复制"值"时

注意:你没有提供你的std::string初始化,但我不认为这是故意的