树结构 - 孩子不正确

Tree structure - incorrect children

本文关键字:不正确 孩子 结构      更新时间:2023-10-16

我正在尝试在C 中构建简单的结构。它应该类似于AVL树。

当我在main()函数中构建一个带有三个节点的简单树时,一切都可以。

问题是当我尝试使用insert()函数时。此函数的第一个参数包含从第二个参数中的值。

中的值。

这是代码:

#include <numeric>
#include <vector>
#include <cstdio>
#include <cstdlib>
using namespace std;
struct Node {
    Node* left;
    Node* right;
    Node* parent;
    int value;
    int count_leafs;
    int height;
};
Node* root;

void insert2(int p, int value, Node* node, int left) 
{
    //printf("insert %d %d - (%d, %d) %d n", p, value, node->left, node->right, left);
    if (root == NULL) {
        //  creating a tree root
        Node new_node;
        new_node.left = NULL;
        new_node.right = NULL;
        new_node.parent = NULL;
        root = &new_node;
        root->value = value;
        root->count_leafs = 1;
        root->height = 1;
        return;
    }
    if (node->left == NULL && node->right == NULL) {
        //  joining value to the leaf
        Node new_parent;
        new_parent.count_leafs = 2;
        new_parent.height = 2;
        new_parent.value = node->value + value;
        new_parent.parent = node->parent;
        new_parent.left = NULL;
        new_parent.right = NULL;
        Node new_leaf;
        new_leaf.value = value;
        new_leaf.count_leafs = 1;
        new_leaf.left = NULL;
        new_leaf.right = NULL;
        new_leaf.height = 1;
        new_leaf.parent = &new_parent;
        new_parent.left = &new_leaf;
        new_parent.right = node;

        if (node->parent != NULL && node->parent->left != NULL && node->parent->left == node) {
            printf("a");
            node->parent->left = &new_parent;
        }
        if (node->parent != NULL && node->parent->right != NULL && node->parent->right == node) {
            printf("b");
            node->parent->right = &new_parent;  
        }
        node->parent = &new_parent;
        return;
    }
    //printf("GOTO: %d %d n", left + node->left->count_leafs, p);
    node->value += value;
    node->count_leafs += 1;
    if (left + node->left->count_leafs + 1 >= p) {
        //printf("W leftn");
        insert2(p, value, node->left, left);
    } else {    
        //printf("W rightn");
        insert2(p, value, node->right, left + node->left->count_leafs);
    }
}

void insert(int p, int value) 
{
    insert2(p, value, root, 0);
}
int main() 
{
    Node new_root;
    root = NULL;
    new_root.value = 10;
    new_root.height = 2;
    new_root.count_leafs = 2;
    new_root.parent = NULL;
    root = &new_root;
    Node left;
    left.value = 6;
    left.height = 1;
    left.count_leafs = 1;
    left.parent = root;
    left.left = NULL;
    left.right = NULL;
    Node right;
    right.value = 4;
    right.height = 1;
    right.count_leafs = 1;
    right.parent = root;
    right.left = NULL;
    right.right = NULL;
    root->left = &left;
    root->right = &right;
    // PLACE A
    insert(0, 1);
    // PLACE B
    return 0;
}

如您之前所见,A的位置是建立一个带有3个节点的树。看起来像是:

  10
 /  
6    4

接下来,在A和位置B之间的一条线中,我想添加一个新节点。之后(在b中)这棵树应该像这样:

    11
   /  
  7    4
 / 
1   6

但是我得到了这样的东西:

            11
           /  
  1972250912   4
     / 
    2   2

我不知道怎么了。它应该是insert2()函数中的问题,但我找不到。

你看到了吗?预先感谢您的帮助!

这种行为的原因是您使用范围内的范围变量。您不得使用指向该范围范围变量指向范围变量的指针。范围变量仅在范围内就存在。如果决定从范围访问示波器变量,您将访问一些堆栈,这些堆栈将覆盖其他数据,从而导致不确定的行为。

我的意思是,您一定不能这样做:

if (root == NULL) 
{
    Node new_node;
    root = &new_node;
    return;
}

您可以使用操作员 new 在堆中创建struct node 的新实例并稍后使用。

if (root == NULL) 
{
    root = new Node;
    return;
}

,但是您稍后必须删除此节点。或者您可以使用智能指针,请参阅此。

阅读此信息,以获取更多信息。

下面的代码可以完成您的期望。但是,它不会删除创建会导致内存泄漏的节点,因此必须改进此代码,但这是一个单独的问题。

#include <numeric>
#include <vector>
#include <cstdio>
#include <cstdlib>
using namespace std;
struct Node {
    Node* left;
    Node* right;
    Node* parent;
    int value;
    int count_leafs;
    int height;
};
Node* root;

void insert2(int p, int value, Node* node, int left)
{
    //printf("insert %d %d - (%d, %d) %d n", p, value, node->left, node->right, left);
    if (root == NULL) {
        //  creating a tree root
        Node* new_node = new Node;
        new_node->left = NULL;
        new_node->right = NULL;
        new_node->parent = NULL;
        root = new_node;
        root->value = value;
        root->count_leafs = 1;
        root->height = 1;
        return;
    }
    if (node->left == NULL && node->right == NULL) {
        //  joining value to the leaf
        Node* new_parent = new Node;
        new_parent->count_leafs = 2;
        new_parent->height = 2;
        new_parent->value = node->value + value;
        new_parent->parent = node->parent;
        new_parent->left = NULL;
        new_parent->right = NULL;
        Node* new_leaf = new Node;
        new_leaf->value = value;
        new_leaf->count_leafs = 1;
        new_leaf->left = NULL;
        new_leaf->right = NULL;
        new_leaf->height = 1;
        new_leaf->parent = new_parent;
        new_parent->left = new_leaf;
        new_parent->right = node;

        if (node->parent != NULL && node->parent->left != NULL && node->parent->left == node) {
            printf("a");
            node->parent->left = new_parent;
        }
        if (node->parent != NULL && node->parent->right != NULL && node->parent->right == node) {
            printf("b");
            node->parent->right = new_parent;
        }
        node->parent = new_parent;
        return;
    }
    //printf("GOTO: %d %d n", left + node->left->count_leafs, p);
    node->value += value;
    node->count_leafs += 1;
    if (left + node->left->count_leafs + 1 >= p) {
        //printf("W leftn");
        insert2(p, value, node->left, left);
    }
    else {
        //printf("W rightn");
        insert2(p, value, node->right, left + node->left->count_leafs);
    }
}

void insert(int p, int value)
{
    insert2(p, value, root, 0);
}
int main()
{
    Node new_root;
    root = NULL;
    new_root.value = 10;
    new_root.height = 2;
    new_root.count_leafs = 2;
    new_root.parent = NULL;
    root = &new_root;
    Node left;
    left.value = 6;
    left.height = 1;
    left.count_leafs = 1;
    left.parent = root;
    left.left = NULL;
    left.right = NULL;
    Node right;
    right.value = 4;
    right.height = 1;
    right.count_leafs = 1;
    right.parent = root;
    right.left = NULL;
    right.right = NULL;
    root->left = &left;
    root->right = &right;
    // PLACE A
    insert(0, 1);
    // PLACE B
    return 0;
}