通用二进制树节点析构函数问题

Generic binary tree node destructor issue

本文关键字:析构函数 问题 树节点 二进制      更新时间:2023-10-16

我一直在做一个赋值,现在我被有缺陷的析构函数卡住了。我必须创建一个通用的二进制树,其中包含所有常用的成员函数和一些特殊的运算符。还有一个限制:一切都必须迭代工作,所以这次不会出现令人讨厌的递归黑客。

BinTreeNode类的析构函数显然有一些非常错误的地方,因为如果我像这样删除节点:

BinTreeNode<int> * node = new BinTreeNode<int>();
delete node; 

我仍然可以访问它的数据:

node->getData(); //should fail miserably

所以删除没有效果,但我不知道该如何更正析构函数。在我看来,算法应该是正确的,所以我怀疑我使用指针的方式有问题,但在这一点上,我非常困惑,甚至不理解自己的代码。

到目前为止我拥有的代码:

BinTree.h

#ifndef BINTREE_H_
#define BINTREE_H_
#ifndef NULL
#define NULL 0
#endif
#include "BinTreeNode.h"
template <class T>
class BinTree
{
    private:
        BinTreeNode<T> * root;
    public:
        //constructors and destructor
        BinTree():
            root(NULL){}
        BinTree(T data):
            root(new BinTreeNode<T>(data)){}
        ~BinTree();
        //search
        BinTreeNode<T> * search(T data);
        //insert
        bool insert(T data);
        //remove
        bool remove(T data);
};
template <class T>
BinTree<T>::~BinTree()
{
    delete root;
}
template <class T>
BinTreeNode<T> * BinTree<T>::search(T data)
{
    BinTreeNode<T> * node = new BinTreeNode<T>(data);
    BinTreeNode<T> * current = root;
    while (current != NULL)
    {
        if (*current == *node)
        {
            delete node;
            return root;
        }
        else if (*node < *current)
        {
            current = current->getLeft();
        }
        else
        {
            current = current->getRight();
        }
    }
    delete node;
    return NULL;
}
template <class T>
bool BinTree<T>::insert(T data)
{
    BinTreeNode<T> * node = new BinTreeNode<T>(data);
    BinTreeNode<T> * current = root;
    while (current != NULL)
    {
        if (*current == *node)
        {
            delete node;
            return false;
        }
        else if (*node < *current)
        {
            if (current->getLeft() == NULL)
            {
                current->setLeft(node);
                return true;
            }
            else
            {
                current = current->getLeft();
            }
        }
        else
        {
            if (current->getRight() == NULL)
            {
                current->setRight(node);
                return true;
            }
            else
            {
                current = current->getRight();
            }
        }
    }
    return false;
}
#endif

BinTreeNode.h

#ifndef BINTREENODE_H_
#define BINTREENODE_H_
#ifndef NULL
#define NULL 0
#endif
template <class T>
class BinTreeNode
{
    private:
        T data;
        BinTreeNode<T> *left, *right, *parent;
    public:
        //constructors and destructor
        BinTreeNode():
            data(NULL), left(NULL), right(NULL), parent(NULL){}
        BinTreeNode(T data):
            data(data), left(NULL), right(NULL), parent(NULL){}
        ~BinTreeNode();
        //set and get data member
        T getData() const;
        void setData(T data);
        //set and get left and right branches
        BinTreeNode<T> * getLeft() const;
        BinTreeNode<T> * getRight() const;
        void setLeft(BinTreeNode<T> * node);
        void setRight(BinTreeNode<T> * node);
        //set and get parent
        BinTreeNode<T> * getParent() const;
        void setParent(BinTreeNode<T> * node);
        //comparison operators
        bool operator<(const BinTreeNode<T>& node) const;
        bool operator>(const BinTreeNode<T>& node) const;
        bool operator==(const BinTreeNode<T>& node) const;
};
template <class T>
BinTreeNode<T>::~BinTreeNode()
{
    BinTreeNode<T> * current = this;
    BinTreeNode<T> * parent = NULL;
    while (current != NULL)
    {
        parent = current->getParent();
        if (current->getLeft() == NULL)
            current = current->getLeft();
        else if (current->getRight() == NULL)
            current = current->getRight();
        else
        {
            if (parent->getRight() == current)
                parent->setRight(NULL);
            else
                parent->setLeft(NULL);
             current = NULL; // this line (among others) is very suspicious
        }
        current = parent;
    }
}
template <class T>
T BinTreeNode<T>::getData() const
{
    return data;
}
template <class T>
void BinTreeNode<T>::setData(T data)
{
    this->data = data;
}
template <class T>
BinTreeNode<T> * BinTreeNode<T>::getLeft() const
{
    return left;
}
template <class T>
BinTreeNode<T> * BinTreeNode<T>::getRight() const
{
    return right;
}
template <class T>
void BinTreeNode<T>::setLeft(BinTreeNode<T> * node)
{
    node->setParent(this);
    left = node;
}
template <class T>
void BinTreeNode<T>::setRight(BinTreeNode<T> * node)
{
    node->setParent(this);
    right = node;
}
template <class T>
BinTreeNode<T> * BinTreeNode<T>::getParent() const
{
    return parent;
}
template <class T>
void BinTreeNode<T>::setParent(BinTreeNode<T> * node)
{
    parent = node;
}
template <class T>
bool BinTreeNode<T>::operator<(const BinTreeNode<T>& node) const
{
        return this->data < node.data;
}
template <class T>
bool BinTreeNode<T>::operator>(const BinTreeNode<T>& node) const
{
    return this->data > node.data;
}
template <class T>
bool BinTreeNode<T>::operator==(const BinTreeNode<T>& node) const
{
    return this->data == node.data;
}
#endif /* BINTREENODE_H_ */

您的BinTreeNode析构函数应该只是:

template <class T>
BinTreeNode<T>::~BinTreeNode() {
    delete left;
    delete right;
}

这将递归地调用左和右的析构函数,释放为这些节点及其子节点分配的内存。因此,这将解放整棵树。

NULL分配给指针不会释放其指向的内存。

另一方面,你提到的,删除后,这一行:

node->getData();

仍然返回数据,这是完全正常的。删除可以释放内存,但存储在其中的数据可能在一段时间内仍然可用,直到在该内存地址中写入新的内容。访问已经空闲的内存地址意味着未定义的行为。

顺便说一句,您应该在C++中使用"0"(不带引号),而不是NULL。因此,没有必要使用#ifndef NULL(…)。

EDIT:我没有看到"无递归"注释。这里有一个非递归算法:

#include <deque>
/* ... */
template <class T>
BinTreeNode<T>::~BinTreeNode() {
    std::deque deq;
    // we're going to delete our children
    deq.push_back(this);
    while(deq.size()) {
        BinTreeNode<T> *ptr = deq.front();
        deq.pop_front();
        if(ptr) {
            deq.push_back(ptr->left);
            deq.push_back(ptr->right);
            // we don't want the child nodes
            // to double delete the children
            ptr->left = 0;
            ptr->right = 0;
            // avoid deleteing ourselves
            if(ptr != this)
                delete ptr;
        }
    }
}

我还没有测试过,但应该可以。