使用 cerr 修复了链表分割错误

linked list segmentation fault fixed with cerr

本文关键字:链表 分割 错误 cerr 使用      更新时间:2023-10-16

我有以下代码。 这段代码的作用是合并两个排序的链表,然后删除两个链表并返回一个新列表:

#include <iostream>
using namespace std;
class node {
    public:
        node(int, node*);
        node* get_next() const;
        void set_next(node*);
        int get_item() const;
        void set_item(int);
    private:
        int item;
        node* next;
};
node* clone_and_destroy(node* a)
{
    node* new_list;
    node* prev;
    node* ret_val;
    while ( a )
    {
        new_list = new node(a->get_item(),NULL);
        if ( prev ){
            prev->set_next(new_list);
            prev = prev->get_next();
        }
        else{
        prev = new_list;
        ret_val = prev;
        }
        node* temp = a;
        a = a->get_next();
        delete temp;
    }
    return ret_val;
}
node* merge(node*& a, node*& b){
    if ( !a ){// cerr<<"r";
        return clone_and_destroy(b);}
    if ( !b )
        return clone_and_destroy(a);
    node* smaller_node, *bigger_node;
    if ( a->get_item() < b->get_item() ){
        smaller_node = a;
        bigger_node = b;
    }
    else {
        smaller_node = b;
        bigger_node = a;
    }
    node* next_node = smaller_node->get_next(); 
    node* merged_list = new node(smaller_node->get_item(),smaller_node->get_next());
    delete smaller_node;
    merged_list->set_next(merge(next_node,bigger_node));
    a = NULL ;
    b = NULL ;
    return merged_list;
}
/*node* merge(node*& a, node*& b){
    if ( !a )
        return b;
    if ( !b )
        return a;
    if ( a->get_item() < b->get_item() ){
        node* a_next = a->get_next();
        node* merged_list = a;
        merged_list->set_next(merge(a_next,b));
        delete a;
        return merged_list;
    }
    else {
        node* b_next = b->get_next();
        node* merged_list = b;
        merged_list->set_next(merge(a,b_next));
        delete b;
        return merged_list;
    }
}*/     
void print(node* a)
{   
    while ( a )
    {
        cout << a->get_item() << " ";
        a = a->get_next();
    }
    cout << endl;
}
node::node(int _item, node* _next)
{
    item = _item;
    next = _next;
}
node* node::get_next() const
{
    return next;
}
void node::set_next(node* new_next)
{
    next = new_next;
}
int node::get_item() const { return item; }
void node::set_item(int _item)
{ 
    item = _item;
}
int main() {
    node* l1 = NULL, *l2 = NULL;
    cout << "Before Merging: " << endl;
    for (int i = 5; i > 0; i--) {
        l1 = new node(i, l1);
        l2 = new node(2*i-3, l2);
    }
    cout << "List 1 is: tt";
    print(l1);
    cout << endl;
    cout << "List 2 is: tt";
    print(l2);
    cout << endl << "After Merging:" << endl;
    node* m = merge(l1, l2);
    cout << "List 1 is: tt";
    print(l1);
    cout << "Should be: tt[ ]" << endl;
    cout << endl;
    cout << "List 2 is: tt";
    print(l2);
    cout << "Should be: tt[ ]" << endl;
    cout << endl;
    cout << "Merged List is: t";
    print(m);
    cout << "Should be: tt[ -1 1 1 2 3 3 4 5 5 7 ]" << endl;

    for (node* h = m; h != NULL; h = m) {
        m = m->get_next();
        delete h;
    }
    return 0;
}

代码的重要部分是合并函数,其余的只是实现这个函数的工具。 现在发生了一件有趣的事情! 当我运行它时,这段代码会出现分段错误,但是当我尝试调试我的代码时,我在合并函数的第一行使用了 cerr(它被注释了),突然它工作正常 !!有人可以向我解释一下吗!? 这个塞尔在做什么?! 以及如何我可以在没有这个 cerr 的情况下修复我的代码并且对代码进行最少的更改吗!?现在我知道 cerr 阻止了 couts 缓冲,但我认为这里不是这样!

*prev 没有用任何东西初始化,您正在尝试访问它。因此赛格。故障。

node* clone_and_destroy(node* a) { .. ..
     if ( prev ){

编辑:初始化它将空修复 seg 错误。 但是你检查它背后的逻辑。

node* prev = NULL;

编辑2:为什么cerr修复分段错误

除非我在代码中放入 printf 语句,否则代码崩溃

从中抽象出"这个问题问"为什么 printf() 语句'修复'事情"。答案是因为它改变了问题。你有一个Heisenbug,因为滥用了分配的内存,而printf()的存在设法稍微改变了代码的行为。