BST的析构函数
Destructor for BST
我必须实现我自己的二叉搜索树。据我所知,除了析构函数之外,一切都很好。下面是一些代码(所有析构函数和构造函数)
Node(){
val = T();
parent=nullptr;
lChild = nullptr;
rChild = nullptr;
}
Node(T &valx){
val=valx;
parent=nullptr;
lChild = nullptr;
rChild = nullptr;
}
Node(const Node &other){
val = other.val;
if(other.lChild!=nullptr){
lChild = new Node(*other.lChild);
lChild->parent=this;
}
else
lChild=nullptr;
if(other.rChild!=nullptr){
rChild= new Node(*other.rChild);
rChild->parent=this;
}
else
rChild=nullptr;
}
~Node(){
if(lChild!=nullptr){
delete lChild;
lChild=nullptr;
}
if(rChild!=nullptr){
delete rChild;
rChild=nullptr;
}
}
和
Set(){
root = nullptr;
sizeOfTree=0;
}
Set(const Set &other){
if(other.root!=nullptr){
root = new Node(*other.root);
root->parent=nullptr;
}
else
root=nullptr;
sizeOfTree=other.sizeOfTree;
}
~Set()
{
if(root!=nullptr){
delete root;
//root->~Node();
root=nullptr;
}
}
对于最简单的测试,valgrind显示了272个错误。谢谢你的帮助
@edit:部分valgrind输出:
==6981== Invalid read of size 8
==6981== at 0x405C29: Set<Pionek>::Node::~Node() (JakbyGomoku4.cpp:53)
==6981== by 0x4049EA: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152)
==6981== by 0x404790: Plansza::~Plansza() (in /media/Dokumenty/Workspace/JakbyGomoku4/Debug/JakbyGomoku4)
==6981== by 0x4015F0: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:718)
==6981== by 0x401746: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:745)
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792)
==6981== Address 0x4c34468 is 24 bytes inside a block of size 40 free'd
==6981== at 0x4A073CC: operator delete(void*) (vg_replace_malloc.c:480)
==6981== by 0x4049F2: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152)
==6981== by 0x401E27: Plansza::Plansza(Plansza const&) (JakbyGomoku4.cpp:315)
==6981== by 0x4015A6: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:718)
==6981== by 0x401746: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:745)
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792)
==6981==
==6981== Invalid read of size 8
==6981== at 0x405C5F: Set<Pionek>::Node::~Node() (JakbyGomoku4.cpp:57)
==6981== by 0x4049EA: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152)
==6981== by 0x404790: Plansza::~Plansza() (in /media/Dokumenty/Workspace/JakbyGomoku4/Debug/JakbyGomoku4)
==6981== by 0x4015F0: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:718)
==6981== by 0x401746: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:745)
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792)
==6981== Address 0x4c34470 is 32 bytes inside a block of size 40 free'd
==6981== at 0x4A073CC: operator delete(void*) (vg_replace_malloc.c:480)
==6981== by 0x4049F2: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152)
==6981== by 0x401E27: Plansza::Plansza(Plansza const&) (JakbyGomoku4.cpp:315)
==6981== by 0x4015A6: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:718)
==6981== by 0x401746: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:745)
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792)
==6981==
==6981== Invalid free() / delete / delete[] / realloc()
==6981== at 0x4A073CC: operator delete(void*) (vg_replace_malloc.c:480)
==6981== by 0x4049F2: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152)
==6981== by 0x404790: Plansza::~Plansza() (in /media/Dokumenty/Workspace/JakbyGomoku4/Debug/JakbyGomoku4)
==6981== by 0x4015F0: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:718)
==6981== by 0x401746: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:745)
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792)
==6981== Address 0x4c34450 is 0 bytes inside a block of size 40 free'd
==6981== at 0x4A073CC: operator delete(void*) (vg_replace_malloc.c:480)
==6981== by 0x4049F2: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152)
==6981== by 0x401E27: Plansza::Plansza(Plansza const&) (JakbyGomoku4.cpp:315)
==6981== by 0x4015A6: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:718)
==6981== by 0x401746: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:745)
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792)
==6981==
==6981== Invalid read of size 8
==6981== at 0x405C6C: Set<Pionek>::Node::~Node() (JakbyGomoku4.cpp:58)
==6981== by 0x4049EA: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152)
==6981== by 0x4057AF: Set<Pionek>::clear() (JakbyGomoku4.cpp:222)
==6981== by 0x40160B: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:731)
==6981== by 0x401746: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:745)
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792)
==6981== Address 0x4c334c0 is 32 bytes inside a block of size 40 free'd
==6981== at 0x4A073CC: operator delete(void*) (vg_replace_malloc.c:480)
==6981== by 0x4049F2: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152)
==6981== by 0x401E27: Plansza::Plansza(Plansza const&) (JakbyGomoku4.cpp:315)
==6981== by 0x4016DE: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:742)
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792)
==6981==
==6981== Invalid write of size 8
==6981== at 0x405C89: Set<Pionek>::Node::~Node() (JakbyGomoku4.cpp:59)
==6981== by 0x4049EA: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152)
==6981== by 0x4057AF: Set<Pionek>::clear() (JakbyGomoku4.cpp:222)
==6981== by 0x40160B: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:731)
==6981== by 0x401746: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:745)
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792)
==6981== Address 0x4c334c0 is 32 bytes inside a block of size 40 free'd
==6981== at 0x4A073CC: operator delete(void*) (vg_replace_malloc.c:480)
==6981== by 0x4049F2: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152)
==6981== by 0x401E27: Plansza::Plansza(Plansza const&) (JakbyGomoku4.cpp:315)
==6981== by 0x4016DE: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:742)
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792)
==6981==
==6981== Invalid read of size 8
==6981== at 0x405C36: Set<Pionek>::Node::~Node() (JakbyGomoku4.cpp:54)
==6981== by 0x4049EA: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152)
==6981== by 0x40479C: Plansza::~Plansza() (in /media/Dokumenty/Workspace/JakbyGomoku4/Debug/JakbyGomoku4)
==6981== by 0x401755: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:748)
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792)
==6981== Address 0x4c33448 is 24 bytes inside a block of size 40 free'd
==6981== at 0x4A073CC: operator delete(void*) (vg_replace_malloc.c:480)
==6981== by 0x4049F2: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152)
==6981== by 0x401DF0: Plansza::Plansza(Plansza const&) (JakbyGomoku4.cpp:314)
==6981== by 0x4016DE: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:742)
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792)
==6981==
==6981== Invalid write of size 8
==6981== at 0x405C53: Set<Pionek>::Node::~Node() (JakbyGomoku4.cpp:55)
==6981== by 0x4049EA: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152)
==6981== by 0x40479C: Plansza::~Plansza() (in /media/Dokumenty/Workspace/JakbyGomoku4/Debug/JakbyGomoku4)
==6981== by 0x401755: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:748)
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792)
==6981== Address 0x4c33448 is 24 bytes inside a block of size 40 free'd
==6981== at 0x4A073CC: operator delete(void*) (vg_replace_malloc.c:480)
==6981== by 0x4049F2: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152)
==6981== by 0x401DF0: Plansza::Plansza(Plansza const&) (JakbyGomoku4.cpp:314)
==6981== by 0x4016DE: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:742)
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792)
除了复制函数和析构函数之外,您还缺少操作符=也不需要在析构函数中检查nullptr,删除nullptr是可以的。
考虑像
Node n1;
//set children for n1
{
Node n2;
//set children for n2
n1 = n2;//Now both n1 and n2 points same children, and initial children of n1 becomes mem leak
}//n2 destructor deletes its children leaving n1 pointing to the same already freed memory location
相关文章:
- 什么时候调用组成单元对象的析构函数
- 如果C++类在类方法中具有动态分配,但没有构造函数/析构函数或任何非静态成员,那么它仍然是POD类型吗
- 内联映射初始化的动态atexit析构函数崩溃
- 什么时候调用析构函数
- 优先顺序:智能指针和类析构函数
- C++-明确何时以及如何调用析构函数
- 使用基类指针创建对象时,缺少派生类析构函数
- 在c++中使用向量时,如何调用构造函数和析构函数
- 重载运算符new[]的行为取决于析构函数
- 我需要知道编译器如何在cpp中使用析构函数
- 为什么在使用转换构造函数赋值后调用C++类的析构函数?
- 析构函数调用
- 通过引用传递-为什么要调用这个析构函数
- 对具有动态分配的内存和析构函数的类对象的引用
- 重载 -> shared_ptr 个实例中的箭头运算符<interface>,接口中没有纯虚拟析构函数
- C++成员的析构函数顺序与shared_ptr
- C++ 防止在映射中放置()时调用析构函数
- 在这种情况下显式调用时,std::cout 如何更改析构函数的行为?
- 调用析构函数以释放动态分配的内存
- BST的析构函数