C++最大的随机数生成器

    //don't forget to like if the solution is working
    //ask ban
    #include <iostream>
    #include <cstdlib>
    #include <time.h>
    using namespace std;
    int max(int Hscore, int Pscore, int Fscore);
    int main()
    {
        srand ( time(NULL) );//(1) 
        int Fscore, Pscore, Hscore, highestScore;
        Fscore = 10 + rand() % 40;
        Pscore = 10 + rand() % 40;
        Hscore = 10 + rand() % 40;
        cout << "Prediction performance of sport teams:" << endl;
        cout << "Team Hoosrand ( time(NULL) );sier's score is " << Hscore << endl;
        cout << "Team Boilermakers' score is " << Pscore << endl;
        cout << "Team Fighting Irish's score is " << Fscore << endl;
        highestScore = max(Hscore, Pscore, Fscore);
        cout<<highestScore;

    return 0;
    }
    int max(int a, int b, int c)
    {
        if(a>b && a>c)//we assume that a is the maximum. This means that a > b and a > c
        {
            return a;
        }
        else // if a is not maximum then we assume that b is maximum
        {
            if(b>c)
            {
                return b;
            }
        }
        return c;// if a and b are not maximum then c is maximum
    }

/（1）这个FCT将帮助您在每次运行程序时都有不同的随机数，更多INF在这里：http://www.cplusplus.com/reference/cstdlib/srand/

如前所述，max 函数需要返回一个并不总是 0 的 int。看起来就像您尝试在函数中使用 cout 在主文件中打印出来一样，但是它不是那样工作的。这会导致一些编译问题。

并且您在分配max结果的行尾缺少一个括号"最高分"。更多编译问题。

此外，您将 max 函数的结果分配给"最高分数"，但然后永远不要使用它。实际上，您正在使用函数"max"本身，该函数可能会导致更多的编译器问题。

这是我的镜头。

 #include <iostream>
 #include <cmath>
 #include <cstdlib>
 using namespace std;
 int max(int Hscore, int Pscore, int Fscore);
 int main()
 {
     int Fscore, Pscore, Hscore, highestScore;
     srand (time(NULL));  // New numbers each time.
     Fscore = 10 + rand() % 40;
     Pscore = 10 + rand() % 40;
     Hscore = 10 + rand() % 40;
     cout << "Prediction performance of sport teams:" << endl;
     cout << "Team Hoosier's score is " << Hscore << endl;
     cout << "Team Boilermakers' score is " << Pscore << endl;
     cout << "Team Fighting Irish's score is " << Fscore << endl;
     highestScore = max(Hscore, Pscore, Fscore);
     if ( (highestScore>Pscore ) && (highestScore>Fscore) ){
       cout << "The largest score is " << highestScore << endl;
       cout << "GO HOOSIER!!!" << endl;
     } else {
       cout << "The largest score is " << highestScore << endl;
     }
 return 0;
 }
 int max(int a, int b, int c) {
   int m = ( a > b ) ? a : b;
   return  ( m > c ) ? m : c;
 }

max函数的实现中存在问题。首先，无论max是什么，您始终return 0。但还有另一个问题。

让我们想象Hscore = 40、Pscore = 40、Fscore = 20并查看函数。

int max(int Hscore, int Pscore, int Fscore)
{
    if (Hscore>Pscore&&Hscore>Fscore){ // False, Hscore > Pscore is false since Hscore is even but not greater than Pscore
        cout << Hscore;}
    else if (Pscore>Hscore&&Pscore>Fscore){  // False, Pscore > Hscore is false since Pscore is even but not greater than Hscore
        cout << Pscore;}
    else{  // else statement gets executed even tho Fscore was the lowest.
        cout << Fscore;}
    return 0;
}

您可能应该在 max 函数中使用 >= 而不是 > 。它应该看起来像这样：

int max(int Hscore, int Pscore, int Fscore)
{
    if (Hscore>=Pscore&&Hscore>=Fscore){
        cout << Hscore;
        return Hscore;
    }
    else if (Pscore>=Hscore&&Pscore>=Fscore){
        cout << Pscore;
        return Pscore;
    }
    else{
        cout << Fscore;
        return Fscore;
    }
}

根据代码示例，我的印象是你拥有的书有点旧（它在函数的开头声明了所有变量，这是 1999 年之前的 C 语言所必需的）。 我强烈建议你买一本更新的书。 就个人而言，我会推荐加速C++或编程：使用C++的原则和实践（由C++的创建者）。

代码中最大的问题是简单的事实，即：

if (max>Pscore&&max>Fscore){

混淆max（函数）和highestScore（变量）。 您希望它是：

if (highestScore>Pscore&&highestScore>Fscore){

虽然，就个人而言，我会把它写成

if (highestScore == Hscore) {

除此之外，您可能有兴趣发现标准库在 <algorithm> 标头中具有函数 max（返回两个项目中较大的一个）和max_element（返回序列中最大的项目）。 您可以将max替换为呼叫max：

int highestScore = std::max(std::max(Hscore, Pscore), Fscore);

或致电max_element：

int scores[] = { Pscore, Fscore, Hscore };
int highestScore = *max_element(scores, scores + 3);