在将空字符串分配给字符串变量时面临核心转储
facing core dump while assigning the empty string to string variable
当我的应用程序试图将文本写入文件时,我正面临核心转储。它使用的是字符串操作,如代码中所示。当多个线程尝试调用此函数并尝试写入日志文件时,我的应用程序正在转储核心。我浏览了不同的论坛,并试图搜索字符串分配中的任何问题。我看到我们中的一些人对字符串赋值语句发表了评论,认为它不适合使用。请改用字符串成员函数。
功能:
void Debug::writeToFile()
{
if(_ptrMutex == NULL)
_ptrMutex = new Mutex();
_ptrMutex->getLock();
write(_fd,_cacheStr.c_str(),_cacheStr.size());
_cacheStr = ""; //flush the write string
_ptrMutex->releaseLock();
}
cacheWriteString
bool Debug::cacheWriteString(string strIn)
{
if(_ptrMutex == NULL)
_ptrMutex = new CndMutex();
_ptrMutex->getLock();
char timeStamp[100];
struct timeval tv;
struct tm tm;
if (gettimeofday(&tv, NULL)==0 && localtime_r((time_t*)&(tv.tv_sec), &tm)) {
int ret = strftime(timeStamp,sizeof(timeStamp),"%F-%T",&tm);
snprintf(timeStamp+ret, sizeof(timeStamp)-ret, ".%03ld", tv.tv_usec/1000);
} else
Time::getTimeStamp(timeStamp,100);
_cacheStr = _cacheStr + "[" + timeStamp + "] " + strIn;
if(_cacheStr.size() >= _maxCacheSize)
{
_ptrMutex->releaseLock();
return true;
}
_ptrMutex->releaseLock();
return false;
}
此函数称为
void Debug::LOG_PRINT_ERROR(char* ptrFormat,...)
{
va_list argList;
va_start(argList,ptrFormat);
if(_logType == CONSOLE_LOG) //console log
{
cout<<"#### [ERROR] ";
vprintf(ptrFormat,argList);
cout<<endl;
}
else if(_logType == SYS_LOG)// [syslog]
{
syslog(LOG_ERR,"%s","[ERROR]####");
vsyslog(LOG_ERR,ptrFormat,argList);
}
else if(_logType == FILE_LOG)
{
char str[1024];
//SBYTE4 ret = vsprintf(str,ptrFormat,argList);
SBYTE4 ret = vsnprintf(str,1023,ptrFormat,argList);
str[1023]=' ';
if(ret > -1)
{
string dataStr = "[ERROR]####";
dataStr = dataStr +str+"n";
if(cacheWriteString(dataStr))
{
if(chkFile() == DIM_PASS)
{
writeToFile();
}
else
{
cout<<"#### LOG_ERROR() Unable to Write Data To File: "<<_fileName <<endl;
}
}
}
else
{
cout<<"#### LOG_ERROR() Output Error Is Encountered: "<<_fileName <<endl;
}
}
va_end(argList);
}
堆芯转储详细信息如下:
Thread 1 (Thread 8426):
#0 0x00a2a402 in __kernel_vsyscall ()
#1 0x0072bdf0 in raise () from /lib/libc.so.6
#2 0x0072d701 in abort () from /lib/libc.so.6
#3 0x0545651a in ?? () from /usr/lib/libstdc++.so.6
#4 0x05456552 in std::terminate() () from /usr/lib/libstdc++.so.6
#5 0x0545668a in __cxa_throw () from /usr/lib/libstdc++.so.6
#6 0x053ed1ef in std::__throw_length_error(char const*) () from /usr/lib/libstdc++.so.6
#7 0x0543211d in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::_Rep::_S_create(unsigned int, unsigned int, std::allocator<char> const&) () from /usr/lib/libstdc++.so.6
#8 0x05433e28 in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_mutate(unsigned int, unsigned int, unsigned int) () from /usr/lib/libstdc++.so.6
#9 0x05433fca in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_replace_safe(unsigned int, unsigned int, char const*, unsigned int) () from /usr/lib/libstdc++.so.6
#10 0x05434065 in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::assign(char const*, unsigned int) () from /usr/lib/libstdc++.so.6
#11 0x0815e9a8 in Debug::writeToFile() ()
#12 0x08161866 in Debug::LOG_PRINT_ERROR(char*, ...) ()
#13 0x0812bcc6 in DimInternalMsgHandler::handlePeerStatusIndication(DimPeerStatusInd*) ()
#14 0x0812c52a in DimInternalMsgHandler::handleInternalMessage(unsigned char*, int) ()
#15 0x0812aa05 in DimDanIfController::handleInMessage(NwPacket&) ()
#16 0x081ab28f in WorkerThreadPool::onEvent(int, nxs_util::EventMessage64*) ()
#17 0x0021dd94 in nxs_util::EventHandler64::workerProc(int) () from /home/nextgen/NXS/lib/libnxsutil.so
#18 0x001c193e in nxs_util::WorkerThread::run() () from /home/nextgen/NXS/lib/libnxsutil.so
#19 0x001c5b36 in nxs_util::Thread::__Thread_run(void*) () from /home/nextgen/NXS/lib/libnxsutil.so
#20 0x0087f832 in start_thread () from /lib/libpthread.so.0
#21 0x007d4e0e in clone () from /lib/libc.so.6
我们怀疑存在<_cacheStr=";>我们在代码中使用的语句。我们正在考虑更改为_cacheStr.clear();但我们现在无法复制这个核心。
如果有人对此有任何想法或面对它,请告诉我们。
非常感谢您的投入。
这看起来真的,真的很危险:
if(_ptrMutex == NULL)
_ptrMutex = new Mutex();
如果两个线程进入这个块并动态地创建它们自己的互斥对象,该怎么办?有什么原因不能在初始化时创建一个互斥体并避免"创建互斥体"竞争条件吗?
如果任何其他线程可以访问_cacheStr
(甚至只是检查它),而_ptrMutex
没有被保存,这很容易导致类似的崩溃。
我看到函数writeToFile有锁定,cacheStr应该是一个全局变量,但我没有看到函数cacheWriteString,所以我认为这是cacheStr变量的竞争条件,该变量在函数cacheWriteString中不受保护。2个线程可以同时访问/修改该字符串。