函数未接收的值

Values not being received by functions

本文关键字:函数      更新时间:2023-10-16

所以我正在尝试制作一个程序,该程序需要一些随机输入的秒数并将其转换为天、小时、分钟和秒。我必须使用符号常量来定义一天中的小时数、一小时中的分钟数和一分钟的秒数。我传递了该值,但它没有被接收,所以我最终得到了一些巨大的负数。这是代码。如果有人能告诉我问题出在哪里,我将不胜感激。

我在函数定义代码中使用了随机代码来输出总秒数,以查看它是否被接收,而不是被接收。

#ifndef SECONDS_H_
#define SECONDS_H_
#define HOURS_IN_DAY 24
#define MINUTES_IN_HOUR 60
#define SECONDS_IN_MINUTES 60
#include <iostream>
using namespace std;
class Seconds
{
private:
    long totalSeconds;
public:
    Seconds();
    ~Seconds(){};
    Seconds(int totalSeconds);
    void Seconds::convertSeconds(int &days, int &hours, int &minutes, int &seconds);
};
#endif

#include <conio.h>
#include <string>
#include <iostream>
#include "seconds.h"
#define HOURS_IN_DAY 24
#define MINUTES_IN_HOUR 60
#define SECONDS_IN_MINUTE 60
Seconds::Seconds(int totalSeconds)
{
    totalSeconds = totalSeconds;
}
void Seconds::convertSeconds(int &days, int &hours, int &minutes, int &seconds)
{   
    cout << endl;
    cout << "Total Seconds: " << totalSeconds;
    cout << endl;
    days = totalSeconds / MINUTES_IN_HOUR / SECONDS_IN_MINUTE / HOURS_IN_DAY;
    hours = (totalSeconds / MINUTES_IN_HOUR / SECONDS_IN_MINUTE) % HOURS_IN_DAY;
    minutes = (totalSeconds / MINUTES_IN_HOUR) % SECONDS_IN_MINUTE;
    seconds = (totalSeconds % SECONDS_IN_MINUTE);
}

#include <iostream>
#include <conio.h>
#include <string>
#include "seconds.h"
#define HOURS_IN_DAY 24
#define MINUTES_IN_HOUR 60
#define SECONDS_IN_MINUTES 60
using namespace std;
int main ()
{
    int totalSeconds;
    int days = 0, hours = 0, minutes = 0, seconds = 0;
    cout << "Enter a random massive amount of seconds: ";
    cin >> totalSeconds;
    Seconds sec(totalSeconds);
    sec.convertSeconds(days, hours, minutes, seconds);
    cout << "That is equivalent to " << days << " days, " << hours << " hours, " << minutes << " minutes, " << seconds << " seconds." << endl;
    cout << "Press any key to continue...";
    cin.sync();
    _getch();
    return 0;
}

这是一个问题:

Seconds::Seconds(int totalSeconds)
{
    totalSeconds = totalSeconds;
}

函数参数totalSeconds隐藏类成员,所以这段代码就像做x = x;一样,对this->totalSeconds没有影响。

要解决此问题,请使用不同的变量名,或者最好使用构造函数初始化语法:

Seconds::Seconds(long totalSeconds)
   : totalSeconds(totalSeconds)
{
}

在此版本中,不会发生阴影,因为构造函数初始化列表是智能的。

您是否考虑过问题可能是整数溢出?